Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow units for page size #2773

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nikischin
Copy link
Contributor

@nikischin nikischin commented Jun 3, 2024

In addition to #2771 I also implemented the support for units "in", "cm", "mm" to the <Page/> size attribute.

Includes the fixes for the dpi from #2771 already but had to be a bit rewritten.

implements #2008

Copy link

changeset-bot bot commented Jun 3, 2024

⚠️ No Changeset found

Latest commit: 0e68df1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nikischin nikischin marked this pull request as ready for review June 24, 2024 06:32
@nikischin
Copy link
Contributor Author

Thank you for merging #2771 @diegomura, in addition I also merged the branch and prepared this PR.

@nikischin nikischin mentioned this pull request Aug 10, 2024
@nikischin
Copy link
Contributor Author

Could you have a look on this please @diegomura? Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant