Skip to content

normalize_property no longer generates NNF #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

normalize_property no longer generates NNF #1191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion regression/ebmc/smv-netlist/always_with_range1.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ always_with_range1.sv
^LTLSPEC node275 & X node275 & X X node275 .*
^LTLSPEC G node275$
^LTLSPEC node275 & X node275 & X X node275 .*
^LTLSPEC G \(\!node306 \| X node337\)$
^LTLSPEC G \(node306 -> X node337\)$
^EXIT=0$
^SIGNAL=0$
--
5 changes: 5 additions & 0 deletions src/temporal-logic/ltl_sva_to_string.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ ltl_sva_to_stringt::rec(const exprt &expr, modet mode)
{
return infix(" xor ", expr, mode);
}
else if(
expr.id() == ID_equal && to_equal_expr(expr).lhs().type().id() == ID_bool)
{
return infix("<->", expr, mode);
}
else if(expr.id() == ID_implies)
{
return infix("->", expr, mode);
Expand Down
4 changes: 0 additions & 4 deletions src/temporal-logic/normalize_property.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ Author: Daniel Kroening, [email protected]
#include <verilog/sva_expr.h>

#include "ltl.h"
#include "nnf.h"
#include "temporal_expr.h"
#include "temporal_logic.h"
#include "trivial_sva.h"
Expand Down Expand Up @@ -112,8 +111,5 @@ exprt normalize_property(exprt expr)
// now do recursion
expr = normalize_property_rec(expr);

// NNF
expr = property_nnf(expr);

return expr;
}
Loading