SMV: move conversion of . and [...] to type checker #1379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
smv-typecheck-index-member
branch
2 times, most recently
from
b53d468 to
dca6318
Compare
kroening
force-pushed
the
smv-typecheck-index-member
branch
from
dca6318 to
b7be5d6
Compare
tautschnig
approved these changes
Nov 5, 2025
src/smvlang/smv_typecheck.cpp
Outdated
Comment on lines
1730
to
1732
| if(member_expr.compound().id() != ID_symbol) | ||
| DATA_INVARIANT_WITH_DIAGNOSTICS( | ||
| false, "unexpected complex_identifier", expr.pretty()); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if(member_expr.compound().id() != ID_symbol) | |
| DATA_INVARIANT_WITH_DIAGNOSTICS( | |
| false, "unexpected complex_identifier", expr.pretty()); | |
| DATA_INVARIANT_WITH_DIAGNOSTICS( | |
| member_expr.compound().id() == ID_symbol, "unexpected complex_identifier", expr.pretty()); |
src/smvlang/smv_typecheck.cpp
Outdated
Comment on lines
1743
to
1745
| if(index_expr.array().id() != ID_symbol) | ||
| DATA_INVARIANT_WITH_DIAGNOSTICS( | ||
| false, "unexpected complex_identifier", expr.pretty()); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if(index_expr.array().id() != ID_symbol) | |
| DATA_INVARIANT_WITH_DIAGNOSTICS( | |
| false, "unexpected complex_identifier", expr.pretty()); | |
| DATA_INVARIANT_WITH_DIAGNOSTICS( | |
| index_expr.array().id() == ID_symbol, "unexpected complex_identifier", expr.pretty()); |
kroening
force-pushed
the
smv-typecheck-index-member
branch
from
b7be5d6 to
6564d5c
Compare
This moves the conversion of the . (dot) and [...] index operators from the SMV parser to the type checker, to enable array index and bit extract operators.
kroening
force-pushed
the
smv-typecheck-index-member
branch
from
6564d5c to
d848ecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the conversion of the
.(dot) and[...]index operators from the SMV parser to the type checker, to enable array index and bit extract operators.