-
Notifications
You must be signed in to change notification settings - Fork 482
Bump the min Gradle and Java requirements to 7.3 and 17 #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Will finish this later. |
cfe3e40
to
7def050
Compare
d94d9c2
to
70d0787
Compare
This is a significant change; the next Gradle plugin release should be 7.1 or another minor version. |
Amazing! Bumping to Gradle Whatever path we choose, this PR is a great starting point. But my first instinct is that we should keep our current compat (Java 11 and Gradle 6.1.1) and then go straight to Java 17 and Gradle 7.3. Does that make sense, or is there a reason to retain support for Gradle 7.1 that I am missing? |
254896e
to
3b66bf0
Compare
I'm fine with dropping Java 11 support. |
d3e013e
to
62973f7
Compare
@EnabledForJreRange(max = JAVA_15) // google-java-format requires JRE 11+ | ||
void behavior18() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
com.diffplug.spotless.Lint$ShortcutException: You are running Spotless on JVM 23. This requires google-java-format of at least 1.17.0 (you are using 1.8).
This is strange.
62973f7
to
2285d03
Compare
2285d03
to
a410746
Compare
No description provided.