Skip to content

[rewrite] apply JavaLangAPIs #2804 #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goooler merged 1 commit into from
Jan 10, 2026
Merged

[rewrite] apply JavaLangAPIs #2804 #2810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# BUILDCACHE_USER
# BUILDCACHE_PASS
# - rw access to buildcache.diffplug.com

Copy link
Contributor Author

@Pankraz76 Pankraz76 Jan 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would help to avoid a lot of noice.

of course the icons are open to debate, im sure you request to remove for the same reason :)

  • image
  • Image

Copy link
Contributor Author

@Pankraz76 Pankraz76 Jan 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nedtwigg let me know if i should adjust or remove the icons. Thanks

@romani see how nice it can be. nice and shiny what check and spot is all about.

🕊️

name: CI 🏭
on:
pull_request:
push:
Expand All @@ -13,7 +13,7 @@ concurrency:
cancel-in-progress: true
jobs:
sanity-check:
name: SanityCheck
name: Sanity Check 🦢
runs-on: ubuntu-latest
env:
buildcacheuser: ${{ secrets.BUILDCACHE_USER }}
Expand All @@ -29,9 +29,9 @@ jobs:
java-version: 21
- name: gradle caching
uses: gradle/actions/setup-gradle@v5
- name: spotlessCheck
- name: Spotless ✨
run: ./gradlew spotlessCheck
- name: rewriteDryRun
- name: Rewrite ♻️
run: ./gradlew rewriteDryRun
- name: assemble testClasses
run: ./gradlew assemble testClasses
Expand Down
2 changes: 1 addition & 1 deletion gradle/rewrite.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ rewrite {
failOnDryRunResults = true
}
dependencies {
rewrite('org.openrewrite.recipe:rewrite-migrate-java:3.22.0')
Copy link
Contributor Author

@Pankraz76 Pankraz76 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort

rewrite('org.openrewrite.recipe:rewrite-java-security:3.22.0')
rewrite('org.openrewrite.recipe:rewrite-migrate-java:3.22.0')
rewrite('org.openrewrite.recipe:rewrite-rewrite:0.16.0')
rewrite('org.openrewrite.recipe:rewrite-static-analysis:2.22.0')
rewrite('org.openrewrite.recipe:rewrite-third-party:0.31.2')
Expand Down
8 changes: 1 addition & 7 deletions rewrite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@ type: specs.openrewrite.org/v1beta/recipe
name: com.diffplug.spotless.openrewrite.SanityCheck
displayName: Apply all Java & Gradle best practices
description: Comprehensive code quality recipe combining modernization, security, and best practices.
tags:
Copy link
Contributor Author

@Pankraz76 Pankraz76 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this.

- java
- gradle
- static-analysis
- cleanup
recipeList:
- org.openrewrite.gradle.EnableGradleBuildCache
- org.openrewrite.gradle.EnableGradleParallelExecution
Expand All @@ -18,6 +13,7 @@ recipeList:
- org.openrewrite.java.format.RemoveTrailingWhitespace
- org.openrewrite.java.migrate.UpgradeToJava17
- org.openrewrite.java.migrate.lang.StringRulesRecipes
- org.openrewrite.java.migrate.util.JavaLangAPIs
Copy link
Contributor Author

@Pankraz76 Pankraz76 Jan 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats actually wrong how could this pass ci..

Recipe validation error in com.diffplug.spotless.openrewrite.SanityCheck for property com.diffplug.spotless.openrewrite.SanityCheck.recipeList[13] (in file:/home/runner/work/spotless/spotless/rewrite.yml): recipe 'org.openrewrite.java.migrate.util.JavaLangAPIs' does not exist.

fixed in:

- org.openrewrite.java.migrate.util.JavaUtilAPIs
- org.openrewrite.java.migrate.util.MigrateInflaterDeflaterToClose
- org.openrewrite.java.migrate.util.ReplaceStreamCollectWithToList
Expand All @@ -38,7 +34,6 @@ recipeList:
- org.openrewrite.staticanalysis.RemoveUnusedLocalVariables
- org.openrewrite.staticanalysis.RemoveUnusedPrivateFields
- org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods
- org.openrewrite.staticanalysis.ReplaceApacheCommonsLang3ValidateNotNullWithObjectsRequireNonNull
Copy link
Contributor Author

@Pankraz76 Pankraz76 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was "just" to see. its very specific, imho should go the simple way.

- org.openrewrite.staticanalysis.SimplifyTernaryRecipes
- org.openrewrite.staticanalysis.URLEqualsHashCodeRecipes
- org.openrewrite.staticanalysis.UnnecessaryCloseInTryWithResources
Expand All @@ -63,5 +58,4 @@ recipeList:
- tech.picnic.errorprone.refasterrules.StreamRulesRecipes
- tech.picnic.errorprone.refasterrules.StringRulesRecipes
- tech.picnic.errorprone.refasterrules.TimeRulesRecipes
# - org.openrewrite.java.migrate.lang.FindVirtualThreadOpportunities # don't want to use: https://github.com/diffplug/spotless/pull/2684#discussion_r2433831887
Copy link
Contributor Author

@Pankraz76 Pankraz76 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was "just" to see. its very specific, imho should go the simple way.

---
Loading