fix: fix Qmax update after load new parsed data#173
Merged
sbillinge merged 3 commits intodiffpy:mainfrom Apr 7, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 69.36% 69.36%
=======================================
Files 25 25
Lines 3457 3457
=======================================
Hits 2398 2398
Misses 1059 1059 🚀 New features to boost your workflow:
|
sbillinge
reviewed
Apr 7, 2026
| # Merge the profiles metadata with our own | ||
| self.meta.update(self.profile.meta) | ||
| self.processMetaData() | ||
| def _on_profile_changed(self, other=()): |
Contributor
There was a problem hiding this comment.
Let's call this _on_profile_update maybe?
Contributor
|
yeh, thans for this @stevenhua0320 .... we finally fixed @rjkoch's bug from 2019! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review. Note that the logic here is pretty the same as before, but the difference is that in the process of loading the metadata, we need to update it right after we load it so that
Qmaxcould be updated. And then we do theself._flushto dump other parameters into theProfile. Since we might need to use it internally multiple times, I made a private function for this. I also did a test on the local for what we can test here #59. Using the script that provided, I confirmed thatQmaxis indeed updated when weloadParsedDataagain.Closes #59