Skip to content

skpkg: use package update to run skpkg on files#87

Merged
sbillinge merged 6 commits intodiffpy:mainfrom
zmx27:package-update
Apr 6, 2026
Merged

skpkg: use package update to run skpkg on files#87
sbillinge merged 6 commits intodiffpy:mainfrom
zmx27:package-update

Conversation

@zmx27
Copy link
Copy Markdown
Contributor

@zmx27 zmx27 commented Apr 3, 2026

No description provided.

@zmx27
Copy link
Copy Markdown
Contributor Author

zmx27 commented Apr 3, 2026

@sbillinge ready for review

Copy link
Copy Markdown
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! thanks @zmx27. Please see the comments. I think it is fine to merge after these are addressed. I asked @vincefn about the app. In general, I would like to keep that in there just so it is easier to do these scikit-package updates in the future and I don't think it does any harm.

@zmx27
Copy link
Copy Markdown
Contributor Author

zmx27 commented Apr 3, 2026

@sbillinge ready for review

Copy link
Copy Markdown
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment, the copyright statement is not quite right and needs to be updated everywhere.

@zmx27
Copy link
Copy Markdown
Contributor Author

zmx27 commented Apr 6, 2026

@sbillinge ready for review

@sbillinge sbillinge merged commit 1d51ebe into diffpy:main Apr 6, 2026
5 checks passed
@zmx27 zmx27 mentioned this pull request Apr 6, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants