Feat/user profile #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dig-ie
requested changes
Nov 25, 2025
Owner
dig-ie
left a comment
dig-ie
left a comment
There was a problem hiding this comment.
- Já temos a atomos (CardSurface) pronto, reutilizar e delelar o novo que foi codado do 0.
- Apagar template por enquanto, está fora do padrão do atomic, depois ajudo nisso
Simplificar atoms, vi que tem 2 components de icon, sendo que a página de profile possui
somente 1 tipo de ícone (círculo com a varíavel de cor Primary de background, que recebe um ícone/provavelmente svg), deveria ser um component só com tamanho parametrizável via props (pelo que entendi, há dois atualmente: "IconsUser" e "Avatar", não deveria).
o Atom "Text" não faz sentido, pode excluir. Não tem estilo fixo nem nada justifica, é basicamente como chamar uma tag p, que vai ter estilo variável em cada local, então não é um component reutilizável.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.