chore: only attempt to run release workflow when merging PR #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
commented
Sep 19, 2024
|
|
||
| jobs: | ||
| release: | ||
| if: github.event.pull_request.merged == true |
There was a problem hiding this comment.
achou11
force-pushed
the
ac/release-workflow-only-on-merge
branch
from
d01d74a
to
2d51a8c
Compare
achou11
force-pushed
the
ac/release-workflow-only-on-merge
branch
from
2d51a8c
to
e5ea022
Compare
EvanHahn
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a couple of things:
Makes sure the pull request is targeting the main branch. Not sure if there are cases where we want this thing to run when that isn't the case
Makes sure that the pull request is actually merged. Before, the workflow was being run when closing a pull request (and not merging), which adds more noise than necessary