Skip to content

Conversation

dlongley
Copy link
Member

No description provided.

@dlongley dlongley requested a review from davidlehn October 12, 2025 19:16
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.41%. Comparing base (97a989b) to head (65b80c0).

Files with missing lines Patch % Lines
lib/meters.js 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   94.06%   93.41%   -0.66%     
==========================================
  Files           5        5              
  Lines         657      668      +11     
==========================================
+ Hits          618      624       +6     
- Misses         39       44       +5     
Files with missing lines Coverage Δ
lib/meters.js 92.32% <61.53%> (-0.78%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a989b...65b80c0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@davidlehn davidlehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many packages that do similar shuffling. Unclear if local implementation is the best idea. But feel free to merge if you think so.

@dlongley dlongley merged commit 572d584 into main Oct 16, 2025
4 checks passed
@dlongley dlongley deleted the replace-shuffle branch October 16, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants