Remove orphaned /admin/images page-images feature#29
Merged
Conversation
The page-images manager (inline URL/alt edit, drag-sort, upload) was complete but unreachable — /admin/images redirected to /admin and there was no nav link. Per decision, remove it the same way the gallery was removed. - Drop routes: the /admin/images redirect and all /admin/api/images* + /admin/api/upload/page-image routes. - Remove handlers (AdminImages, APIUpdateImageURL/Alt/SortOrder, APIUploadPageImage), the admin_images template, the PageImage model, and the PageImages dashboard stat. - DB table + sqlc page_images queries are left in place (no destructive migration), matching the gallery removal. Note: admin.js still contains the now-unused inline-edit/sortable/upload helpers (harmless no-ops); left as-is to match the gallery removal and can be cleaned up separately. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the admin audit. The page-images manager (
/admin/images) was a complete, working feature (inline URL/alt editing, drag-sort, upload) but unreachable — the route redirected to/adminand there was no sidebar link. Removed it the same way the gallery was removed./admin/imagesredirect and all/admin/api/images*+/admin/api/upload/page-imageroutes.AdminImages,APIUpdateImageURL/Alt/SortOrder,APIUploadPageImage), theadmin_imagestemplate, thePageImagemodel, and thePageImagesdashboard stat.page_imagesqueries left in place (no destructive migration), matching the gallery removal.admin.jsstill has the now-unused inline-edit/sortable/upload helpers (harmless no-ops) — left as-is to match the gallery removal; can be cleaned up separately.Test plan
go build ./...+go build -tags dev ./...,go test -race ./...(both tags),golangci-lint run→ 0 issues/admin/images,/admin/api/images/:id/url,/admin/api/upload/page-image/:id→ 404/admin,/content,/contacts,/users,/settings) → 200🤖 Generated with Claude Code