feat(lessons): record failed-run lessons#91
Merged
Conversation
4 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a57ede7d8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary: - Add repository-local lessons storage with rolling cap and recent recall. - Inject recent lessons into first-turn prompts when the feature is enabled. - Capture HEAD-unchanged runs with Codex post-mortems and fallback text. - Document the agent.lessons config and add focused coverage. Rationale: - Failed runs currently lose useful context before the next dispatch. - A plain markdown file keeps the memory reviewable and versionable with the target repository while leaving commit policy to maintainers. Tests: - mise exec -- mix test test/symphony_elixir/lessons_test.exs test/symphony_elixir/agent_runner_lessons_test.exs test/symphony_elixir/workspace_and_config_test.exs - mise exec -- make all Co-authored-by: Codex <codex@openai.com>
corylanou
force-pushed
the
symphony/digitaldrywood_symphony_89
branch
from
a57ede7 to
d18295b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Adds opt-in lessons memory for failed Symphony runs. Fixes #89.
TL;DR
Record HEAD-unchanged lessons and recall them into future prompts.
Summary
agent.lessonsis enabled.agent.lessonsconfig and add focused storage and runner tests.Alternatives
Test Plan
make -C elixir allmise exec -- mix test test/symphony_elixir/lessons_test.exs test/symphony_elixir/agent_runner_lessons_test.exs test/symphony_elixir/workspace_and_config_test.exs