Skip to content

fix(github): don't synthesize branch_name, defer to workspace fallback #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corylanou wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(github): don't synthesize branch_name, defer to workspace fallback #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions elixir/lib/symphony_elixir/github/client.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ defmodule SymphonyElixir.GitHub.Client do
description: content["body"],
priority: Priority.rank_for(priority_name, ctx.priority_map),
state: github_to_symphony_state(status_name, ctx.state_map),
branch_name: derive_branch_name(number, title),
branch_name: nil,
model_override: parse_model_override(content["body"]),
url: content["url"],
assignee_id: first_assignee_login(assignees),
Expand All @@ -694,22 +694,6 @@ defmodule SymphonyElixir.GitHub.Client do
defp build_identifier(_repo, number) when is_integer(number), do: "##{number}"
defp build_identifier(_repo, _number), do: nil

defp derive_branch_name(number, title) when is_integer(number) and is_binary(title) do
slug =
title
|> String.downcase()
|> String.replace(~r/[^a-z0-9]+/, "-")
|> String.trim("-")
|> String.slice(0, 50)

case slug do
"" -> "issue-#{number}"
s -> "issue-#{number}-#{s}"
end
end

defp derive_branch_name(_number, _title), do: nil

defp parse_model_override(body) when is_binary(body) do
case Regex.run(~r/<!--\s*model:\s*(\S+?)\s*-->/i, body) do
[_match, model] -> String.trim(model)
Expand Down
Loading