CON-11819 spread sync of load balancers #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llDrLove
changed the title
d-honeybadger
approved these changes
Feb 14, 2025
| @@ -85,6 +86,14 @@ func (s *tickerSyncer) Sync(name string, period time.Duration, stopCh <-chan str | |||
| klog.Errorf("%s failed: %s", name, err) | |||
| } | |||
|
|
|||
| initialDelayTicker := time.NewTicker(initialDelay) | |||
| defer initialDelayTicker.Stop() | |||
There was a problem hiding this comment.
(nit) could use time.After() https://pkg.go.dev/time#After instead of ticker
There was a problem hiding this comment.
Using time.After() instead. Thanks
| @@ -126,7 +135,7 @@ func (r *ResourcesController) Run(stopCh <-chan struct{}) { | |||
| klog.Info("No cluster ID configured -- skipping cluster dependent syncers.") | |||
| return | |||
| } | |||
| go r.syncer.Sync("tags syncer", controllerSyncTagsPeriod, stopCh, r.syncTags) | |||
| go r.syncer.Sync("tags syncer", controllerSyncTagsPeriod, time.Second*time.Duration(rand.Int31n(300)), stopCh, r.syncTags) | |||
There was a problem hiding this comment.
Now that it's initial delay, maybe let's increase the spread to ~10 min?
There was a problem hiding this comment.
Bumped to 600 (10minutes)
d-honeybadger
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spread the sync period of the loadbalancer unevenly to prevent a spike of loadbalancer API calls at the same time. We saw an issue when multiple clusters see their maintenance window happening at the same time and the CCM component is restarted at the same time. The sync tag period will match closely for all those CCM pods and all of those clusters will make a LIST api calls relatively close to each other resulting in spikes each 15minutes. This PR attempts to mitigate this issue by adding some randomness to the sync period (5minutes) as an initial delay. Thus, the new sync period will remain 15 minutes but the subsequent sync tag will be off between 0 to 300 seconds.