-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NETPROD-3585] Added name filter in doctl for certificates #1509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the changes be tested locally apart from the unit tests?
Yes. We can do go install & try it. I was not able to do it on my machine due to multiple set up issues. But this pattern & code is being used everywhere so it gives confidence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
@guptado, @apinonformoso - You should be able to build doctl locally by running |
Thanks! It seems to be working fine. @apinonformoso below is the output the commands ./builds/doctl compute certificate list --name bindiya-certificate ID Name DNS Names SHA-1 Fingerprint Expiration Date Created At Type State 33c30d70-908a-4ed2-9c4f-6f2544071c11 bindiya-certificate fertileearth.in,cdn.fertileearth.in ae4af8aaf7f4011a383da3997b8b06c1fb748529 2024-05-05T17:30:04Z 2024-02-05T18:30:02Z lets_encrypt verified |
NETPROD-3585