add TLS support #11
Merged
add TLS support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorkuehl
force-pushed
the
ck/additional_transport_tests
branch
from
9cb16d5 to
dc9b86b
Compare
Current version seems to disagree with both Go 1.24 and the examples directory.
connorkuehl
force-pushed
the
ck/additional_transport_tests
branch
2 times, most recently
from
e1762ed to
fa3abbf
Compare
When adding additional integration tests around dialing over TLS I learned that the original implementation just simply never ever worked. The NBD server state machine still expects to begin option negotiation outside of TLS, one of which must be OPT_STARTTLS in order to upgrade the existing connection to a secure one, rather than expecting a TLS handshake and then engaging in option negotation. I've added support for NBD_OPT_STARTTLS along with a corresponding integration test.
connorkuehl
force-pushed
the
ck/additional_transport_tests
branch
from
fa3abbf to
c2cdc0a
Compare
dclutter-do
approved these changes
Feb 18, 2025
DulioCagg
reviewed
Feb 18, 2025
DulioCagg
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding additional integration tests around dialing over TLS I
learned that the original implementation just simply never ever worked.
The NBD server state machine still expects to begin option negotiation
outside of TLS, one of which must be OPT_STARTTLS in order to upgrade
the existing connection to a secure one, rather than expecting a TLS
handshake and then engaging in option negotation.
I've added support for NBD_OPT_STARTTLS along with a corresponding
integration test.