fix partner interconnect attachment json request response #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apinonformoso
changed the title
danaelhe
reviewed
Feb 27, 2025
| @@ -73,7 +74,13 @@ func (req *PartnerInterconnectAttachmentCreateRequest) buildReq() *partnerInterc | |||
| } | |||
|
|
|||
| if req.BGP != (BGP{}) { | |||
| request.BGP = &req.BGP | |||
| request.BGP = &BGPInput{ | |||
There was a problem hiding this comment.
Would the tests need to be updated to reflect this change as well?
https://github.com/digitalocean/godo/blob/main/partner_interconnect_attachments_test.go#L22
There was a problem hiding this comment.
true, the update should be the json response of the request.
Done 6e46cd0
apinonformoso
force-pushed
the
VPC-3920/fix-json-tag-req-res
branch
from
05d1ecd to
6e46cd0
Compare
danaelhe
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request is expecting BGP config input with fields as
local_router_asnandpeer_router_asnbut response should be in the form oflocal_asnandpeer_asn