Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiRegistry Beta API #944
base: main
Are you sure you want to change the base?
MultiRegistry Beta API #944
Changes from 15 commits
2f96a5a
8075611
6db6f21
c5b53c1
85995e1
caa8750
5c535be
41c1caf
df4b5dc
dea9984
7785fe2
aa27aa2
6d6556f
754d60d
f1156f6
8c79d4b
daa59f7
39ec460
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, these are generated from the operation ID. So at the moment, that would actually be
client.multiregistry.create
, but I think we really wantclient.registries.create
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got you @andrewsomething. Just for my information, is the python client generated automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Python client is generated automatically as soon as
openapi
changes merged tomain
branch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nearly identical to the existing registry model. It's just missing the
subscription
piece. I wonder if we could do this in a way that doesn't require duplication?Maybe something like rename this to
models/registry_base.yml
and update themodels/registry.yml
to be:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome suggestion @andrewsomething. I have created
models/registry_base.yml
and updatedmodels/multiregistry.yml
andmodels/registry.yml
to import from it. Please lemme know if it looks good now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put the beta tag up front for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. I had to put it inside quotes or else the operation was not visible in the rendered spec.