Expose git commit in /health; verify deploys by commit; bump actions - #18
Merged
Conversation
Follow-ups from the ops registry migration to pull-based deploys: - /health now includes the commit field (GIT_COMMIT already flows in via Docker build-arg -> version.json -> version.ts; it just wasn't exposed) - deploy-dev wait step verifies by commit instead of package version - version matching cannot distinguish a same-version commit from a stale deploy. A healthy host serving the wrong commit after 6 min is now a failure, not a warning (one transitional warning while the running image predates the commit field) - deploy-prod wait step prefers commit verification, keeping the version match only as a fallback for the pre-commit-field image - actions/checkout and actions/setup-node bumped v4 -> v5 (Node 20 runner deprecation warnings) - CLAUDE.md deployment section rewritten for the pull-based flow (compose is a reference copy; :latest is dev-only)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from ops' migration to the Monza registry and pull-based deploys:
/healthnow reports the git commit. Ops noted the wait step couldn't prove a deploy — package version doesn't change on every commit, so a stale container is indistinguishable from a fresh one.GIT_COMMITalready reaches the build as a build-arg; this exposes it in the health payload./health's commit againstgithub.sha; a healthy host serving the wrong commit after 6 minutes fails the run instead of warning. One transitional warning is expected on the first deploy (the running image predates the commit field). Prod gets the same commit-first check with the version match kept as fallback.actions/checkoutandactions/setup-nodebumped v4 → v5 (Node 20 runner deprecation warnings flagged by ops).:latestis dev's tag only.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_016LdzWqfHMC51154WW2oSZc