Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort if malloc fails #627

Merged
merged 14 commits into from
Apr 3, 2024
Merged

Abort if malloc fails #627

merged 14 commits into from
Apr 3, 2024

Conversation

DanielPointon
Copy link
Contributor

No description provided.

@DanielPointon DanielPointon marked this pull request as draft March 14, 2024 22:46
@james-d-mitchell james-d-mitchell added the refactor Label for PRs or issues related to refactoring code label Mar 15, 2024
@DanielPointon DanielPointon marked this pull request as ready for review March 25, 2024 03:13
@DanielPointon DanielPointon changed the title [Draft] Abort if malloc fails Abort if malloc fails Mar 25, 2024
@james-d-mitchell james-d-mitchell added the rerun-ci A label for PR's to indicate that the ci should be rerun (possibly after a rebase) label Mar 27, 2024
@james-d-mitchell
Copy link
Member

Just to say that I've rebased this onto the current main which should fix the ci.

@james-d-mitchell james-d-mitchell removed the rerun-ci A label for PR's to indicate that the ci should be rerun (possibly after a rebase) label Mar 28, 2024
james-d-mitchell
james-d-mitchell approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few minor changes to this, I don't think it's possible to test these functions at present (i.e. to test that an error is given if c/malloc fails) but I'm happy to merge this if the CI passes.

@james-d-mitchell james-d-mitchell merged commit bc224d1 into digraphs:main Apr 3, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-d-mitchell james-d-mitchell james-d-mitchell approved these changes

Assignees
No one assigned
Labels
refactor Label for PRs or issues related to refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielPointon @james-d-mitchell