Fix compile warnings #648

Joseph-Edwards · 2024-05-10T16:22:17Z

This PR continues the work form #633 by fixing compiler warnings for GCC.

james-d-mitchell · 2024-05-10T20:36:02Z

Seems like the file is being reformatted which makes it a bit hard to see what the actual changes are. Also do we expect the ci to fail?

Joseph-Edwards · 2024-05-13T13:30:21Z

I've undone that formatting, so it should now be clearer what the changes are. I didn't expect the CI to fail, but since we are planning on dropping the support for GAP 4.10, can this be ignored or does it still warrant investigation? @james-d-mitchell

Joseph-Edwards · 2024-05-13T14:17:17Z

I didn't expect the CI to fail, but since we are planning on dropping the support for GAP 4.10, can this be ignored or does it still warrant investigation?

In case there was a fundamental error, I decided to investigate. In ci/docker-test.sh, for version 4.10, GAPDoc is being cloned using

URL="http://www.math.rwth-aachen.de/~Frank.Luebeck/GAPDoc/GAPDoc-$VERSION.tar.gz"

but this link appears to be dead. This is what was causing the 4.10 tests to fail.

Changing the above to

URL="https://github.com/frankluebeck/GAPDoc/archive/refs/tags/relv$VERSION.tar.gz"

seems to fix the problem. Since the 4.10 jobs will soon be dropped, it doesn't seem like there is any need to make the above change.

james-d-mitchell · 2024-05-13T15:06:51Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphDFSUtils.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:07:01Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphDrawPlanar.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:07:17Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphDrawPlanar_Extensions.c


 #include <stdlib.h>

 #include "graphDrawPlanar.private.h"
 #include "graphDrawPlanar.h"
-
-
+


Still formatting changes here

james-d-mitchell · 2024-05-13T15:07:23Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphDrawPlanar_Extensions.c

@@ -59,7 +63,7 @@ void _DrawPlanar_FreeContext(void *);
 /****************************************************************************
 * DRAWPLANAR_ID - the variable used to hold the integer identifier for this
 * extension, enabling this feature's extension context to be distinguished
- * from other features' extension contexts that may be attached to a graph.
+ * from other features' extension contexts that may be attached to a graph.


james-d-mitchell · 2024-05-13T15:07:29Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphEmbed.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:07:39Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphExtensions.c

@@ -30,7 +37,7 @@ graphExtensionP _FindNearestOverload(graphP theGraph, graphExtensionP target, in
 * An ID identifies an extension, which may be added to multiple
 * graphs.  It is used in lieu of identifying extensions by a string
 * name, which is noticeably expensive when a frequently called
- * overload function seeks the extension context for a graph.
+ * overload function seeks the extension context for a graph.


More format changes

james-d-mitchell · 2024-05-13T15:07:52Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphFunctionTable.h

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:07:59Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphIsolator.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:08:05Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphK23Search.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:08:11Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphK23Search_Extensions.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:08:17Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphK33Search.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:08:24Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphK33Search_Extensions.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:08:33Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphK4Search.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:08:41Z

extern/edge-addition-planarity-suite-Version_3.0.1.0/c/graphK4Search_Extensions.c

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+


Suggested change

james-d-mitchell · 2024-05-13T15:09:32Z

Bunch of minor changes please @Joseph-Edwards, please remove the blank lines at the end of every #if defined pragma block (as partially indicated in the comments).

Joseph-Edwards mentioned this pull request May 10, 2024

Refactor CI #641

Merged

james-d-mitchell force-pushed the fix-compile-warnings branch from 6c1ddc2 to 1ef1ff2 Compare May 13, 2024 08:15

james-d-mitchell added the C language A label for issues or pull requests relating to the kernel module of the package label May 13, 2024

Fix compile warnings for GCC

0de66b9

Joseph-Edwards force-pushed the fix-compile-warnings branch from 1ef1ff2 to de4ee1d Compare May 13, 2024 13:16

Joseph-Edwards added 2 commits May 13, 2024 14:20

Add empty default case

0165dbc

Initialise adj and free unconditionaly

0ef0622

Joseph-Edwards force-pushed the fix-compile-warnings branch from de4ee1d to 0ef0622 Compare May 13, 2024 13:20

james-d-mitchell reviewed May 13, 2024

View reviewed changes

Remove blank lines

057cf41

james-d-mitchell merged commit 3b42ed7 into digraphs:main May 13, 2024
16 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix compile warnings #648

Fix compile warnings #648

Joseph-Edwards commented May 10, 2024

james-d-mitchell commented May 10, 2024

Joseph-Edwards commented May 13, 2024

Joseph-Edwards commented May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell May 13, 2024

james-d-mitchell commented May 13, 2024

Fix compile warnings #648

Fix compile warnings #648

Conversation

Joseph-Edwards commented May 10, 2024

james-d-mitchell commented May 10, 2024

Joseph-Edwards commented May 13, 2024

Joseph-Edwards commented May 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

james-d-mitchell commented May 13, 2024