Skip to content

Warnings when loading a package causes CI to fail #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Warnings when loading a package causes CI to fail #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8280c33
Add warning checker
Joseph-Edwards Jun 26, 2024
270ef8b
Find warnings
Joseph-Edwards Jun 26, 2024
63337b2
update action name
Joseph-Edwards Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...hub/actions/test_with_valgrind/action.yml → .github/actions/run-pkg-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,20 @@ runs:
# Load the package with debug info
SetInfoLevel(InfoPackageLoading, PACKAGE_DEBUG);
SetPackagePath(info.PackageName, "/tmp/gaproot/pkg/$(basename $PWD)");
output := "";
output_stream := OutputTextString(output, true);
SetPrintFormattingStatus(output_stream, false);
OutputLogTo(output_stream);
if ${{ inputs.only-needed }} = true then
LoadPackage(info.PackageName : OnlyNeeded);
else
LoadPackage(info.PackageName);
fi;
OutputLogTo();
CloseStream(output_stream);
if PositionSublist(output, "warning") <> fail then
Error("Warnings were found when loading the package");
fi;
SetInfoLevel(InfoPackageLoading, PACKAGE_ERROR);
Print("Now running tests from ", GAP_TESTFILE, "\n");
if EndsWith(GAP_TESTFILE, ".tst") then
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/os.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,22 +54,26 @@ jobs:
curl --retry 5 -L -O "https://digraphs.github.io/Digraphs/${{ env.DIGRAPHS_LIB }}.tar.gz"
tar xf "${{ env.DIGRAPHS_LIB }}.tar.gz"
- name: Run DigraphsTestInstall . . .
uses: gap-actions/run-pkg-tests@v2
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/install.g
- name: Run DigraphsTestStandard . . .
uses: gap-actions/run-pkg-tests@v2
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/standard.g
- name: Run DigraphsTestManualExamples . . .
uses: gap-actions/run-pkg-tests@v2
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/examples.g
- name: Run DigraphsTestExtreme . . .
uses: gap-actions/run-pkg-tests@v2
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/extreme.g
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,25 +54,29 @@ jobs:
curl --retry 5 -L -O "https://digraphs.github.io/Digraphs/${{ env.DIGRAPHS_LIB }}.tar.gz"
tar xf "${{ env.DIGRAPHS_LIB }}.tar.gz"
- name: Run DigraphsTestInstall . . .
uses: gap-actions/run-pkg-tests@v2
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/install.g
only-needed: ${{ matrix.only-needed }}
- name: Run DigraphsTestStandard . . .
uses: gap-actions/run-pkg-tests@v2
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/standard.g
only-needed: ${{ matrix.only-needed }}
- name: Run DigraphsTestManualExamples . . .
uses: gap-actions/run-pkg-tests@v2
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/examples.g
only-needed: ${{ matrix.only-needed }}
- name: Run DigraphsTestExtreme . . .
uses: gap-actions/run-pkg-tests@v2
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/extreme.g
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/valgrind.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ jobs:
uses: gap-actions/build-pkg@v1
- name: Run DigraphsTestInstall . . .
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/test_with_valgrind
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/install.g
pre-gap: ${{ env.VALGRIND }}
- name: Run DigraphsTestStandard . . .
# TODO: Replace below with gap-actions/run-pkg-tests@v2 if the functionality gets added
uses: ./.github/actions/test_with_valgrind
uses: ./.github/actions/run-pkg-tests
with:
NO_COVERAGE: true
GAP_TESTFILE: tst/github_actions/standard.g
Expand Down