Fix issue 704 #709
Merged
Fix issue 704 #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [mamba-org/setup-micromamba](https://github.com/mamba-org/setup-micromamba) from 1 to 2. - [Release notes](https://github.com/mamba-org/setup-micromamba/releases) - [Commits](mamba-org/setup-micromamba@v1...v2) --- updated-dependencies: - dependency-name: mamba-org/setup-micromamba dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
Thank you very much! This solves my problem and I have also tested several examples. Sorry it took so long, but while testing I found a bug in my code :) |
MeikeWeiss
approved these changes
Oct 30, 2024
james-d-mitchell
force-pushed
the
fix-issue-704
branch
from
d1346eb
to
03e549e
Compare
james-d-mitchell
force-pushed
the
fix-issue-704
branch
from
03e549e
to
2c73819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #704. It seems that the previously installed method for
SubdigraphsMonomorphismswas just wrong (right in all the examples we checked but not all). This PR re-implements the method, this time hopefully correct. The performance is unfortunately worse than the previous incorrect method, I might be able to do something about that but it might be more or less complicated, so I thought I'd post this.@MeikeWeiss can you please take a look and confirm that this resolves your issue?