Use gap-actions/run-pkg-tests
#743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [gap-actions/run-pkg-tests](https://github.com/gap-actions/run-pkg-tests) from 2 to 3. - [Commits](gap-actions/run-pkg-tests@v2...v3) --- updated-dependencies: - dependency-name: gap-actions/run-pkg-tests dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Joseph-Edwards
force-pushed
the
update-ci
branch
from
bb45e8d to
a8e4579
Compare
|
The Valgrind action hasn't been triggered, so I am testing it here: |
|
Thanks @Joseph-Edwards is this ready? Why did the job not trigger? |
|
Yeah this is ready to go. It seems like the Valgrind job only gets triggered on releases or when the C code gets edited, so it's non-run was to be expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #666, we added a custom action in place of https://github.com/gap-actions/run-pkg-tests that treats warnings as errors and makes running Valgrind easier. As of gap-actions/run-pkg-tests#35, this is now integrated into the gap action.
This PR reuses the gap action.