Rename IsHamiltonianPath to IsHamiltonianCycle
#824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
added
not-backwards-compatible
wilfwilson
force-pushed
the
HamiltonianPath-to-HamiltonianCycle
branch
from
4922203 to
f454d8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @TomGoertzen in #545, our attribute
HamiltonianPathonly looks for and returns Hamiltonian cycles, even though the more general notion of a Hamiltonian path that is not necessarily a cycle does exist (see e.g. beloved Wikipedia https://en.wikipedia.org/wiki/Hamiltonian_path).Accordingly I've renamed
HamiltonianPathtoHamiltonianCyclein this PR. I will also separately create an issue to implement a newHamiltonianPaththat returns a Hamiltonian path, and would work for e.g. a chain digraph. Update: that issue is #825.Resolves #545 (pending release of Digraphs 2.0).