-
Notifications
You must be signed in to change notification settings - Fork 60
Add SwapDigraphs and DigraphsRemoveAllEdges functions
#864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, especially for your first pull request. I've suggested a load of changes (we always do this) so it'd be great if you could make those changes and we can get this merged. Sorry for the major changes I'm requesting to the core algorithm!
SwapDigraphs and DigraphsRemoveAllEdges functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent start, but this Pr will need some changes before it can be merged, let's discuss tomorrow!
Mostly fixed, with remaining problems covered by @james-d-mitchell's review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close to complete now. Just a couple more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me now!
I think @james-d-mitchell's suggestions have now been fixed, but I'll let him approve before merging.
|
Very nice. |
Created
SwapDigraphsto swap the contents of two digraphs, and addedDigraphsRemoveAllEdgesfor removing all edges from a digraph