Add 64bit support #47

Activity

1. Ughuuu commented on Oct 9, 2024

   

   Ughuuu

   on Oct 9, 2024

   ContributorAuthor

   More actions

   For this issue one should look at how rapier does it: https://github.com/dimforge/rapier
   And basically it needs in salva multiple packages exported, similar to how rapier has. So right now this exports salva2d and salva3d, it would need salva2d-f64 and salva3d-f64. Each of these would be defined in the Cargo.toml file and then there would be a define for the precision:

   • https://github.com/dimforge/rapier/blob/master/crates/rapier2d/Cargo.toml#L32 (Rapier defining f32 feature)
   • https://github.com/dimforge/rapier/blob/master/crates/rapier3d-f64/Cargo.toml#L32 (Rapier defining f64 feature)

   So in the build directory of salva there would be 2 new folders, salva2d-f64 and salva3d-f64. Then in github workflows there needs to be automatic building (and deploying?) of the new packages.

   Example of how to use the f32 and f64 flags:

   • https://github.com/dimforge/rapier/blob/master/src/lib.rs#L19
2. Ughuuu commented on Jun 27, 2026

   

   Ughuuu

   on Jun 27, 2026

   ContributorAuthor

   More actions

   Also fixed by latest PR. #69 (aside for publishing to crates.io).
3. Ughuuu

   closed this as completedon Jun 27, 2026