Unbreak el-get-remove-autoloads for Emacs < 28 #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from Emacs 28 the function autoload-file-load-name takes two non-optional parameters, but versions before Emacs 27 still takes only one.
Because string-join doesn't exist for Emacs 24.3 and before.
|
Yes, will do this over the weekend and get back to you
…On Sat, Jun 12, 2021, 2:00 AM stephan-cr ***@***.***> wrote:
@tarao <https://github.com/tarao> @vedang <https://github.com/vedang>
Could you help out to check these changes for Emacs 28?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2835 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUUHT32SKNFXS23ET2G3DTSJW7XANCNFSM46RKPMTQ>
.
|
|
👍 Tested that removing an installed package works. Tested that reinstalling the removed package works. LGTM. |
|
Thank you, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Emacs 28 the function
autoload-file-load-nametakes two non-optional parameters, but versions before Emacs 27 still takes only one. Furthermore, replacestring-joinbymapconcat, becausestring-joindoesn't exist before Emacs 24.4.This PR fixes #2833.