make less id calls

[dimven-adsk]

List of Affected Nodes/Modules

All nodes that wrap or create Revit elements

Current Performance

Every time an element is wrapped, we store its id and unique id. Then the native element is passed to the element binder and the id and unique id properties are fetched again. It didn't make sense to me to pay the cost of fetching those twice after already referencing them (plus also allocating the memory):

Proposed Performance

We should not pass the native element but the already extracted id and unique ids:

The cost is mostly from fetching the unique id/ Unfortunately, the performance benefit did not quite pan out the way I expected it to (should have reduced the get_UniqueId total cpu time by at least half)

Dynamo Tuneup Comparison

With a very basic graph that fetches 25k elements and creates 10k instances the performance gain is negligible and we go from 4.7 seconds on average down to 4.6:

Overall I am not entirely sure if this change is worth it due to the large code change.

Checklist

• There are no public function signature changes
• Any public code that is no longer in use is tagged as obsolete and preserved.
• The code changes have been documented
• The overall behavior does not change