Improve wrapper performance

[dimven-adsk]

List of Affected Nodes/Modules

All Revit nodes that create a wrapper element

Current Performance

Currently every single time an element wrapper is created, an unnecessary assertion is performed to ensure that this wrapper is unique. This assertion is not logged or displayed to the user and from what I can tell, does not benefit them.

Proposed Performance

The best performance optimization is to avoid doing work :) . If there is no clear benefit to do this assertion every time, I propose we remove it from the release builds and only keep it there for debug builds. The performance benefit is small at face value but would add up over time in a large graph.

Dynamo Tuneup Comparison

On a model with ~55k elements collecting all elements 10 times improves performance about 8%, from 10.5 seconds to about 9.6 seconds on average.

Checklist

• There are no public function signature changes
• Any public code that is no longer in use is tagged as obsolete and preserved.
• The code changes have been documented
• The overall behavior does not change

[Mikhinja]

We are changing behavior by removing the validity check, it will no longer give warnings for users. But I'm fine with that, debug is slower anyway and for good reasons, like this one.