Inlining Element Wrapping

[dimven-adsk]

List of Affected Nodes/Modules

All nodes returning a wrapped element would benefit

Current Performance

The current implementation works perfectly fine. However the newer C# language features do provide some performance advantages here. This change does get rid of the previous public wrapper methods and might potentially cause issues if any external code was relying on them.

Proposed Performance

we manually inline all of the one-liner wrap methods into a single pattern matching switch table.

Dynamo Tuneup Comparison

On the standard arch. sample model collecting all elements of all categories five times over (about 125k element conversions in total), we can improve performance from 71 seconds on average down to about 66 seconds.

This change might make the ElementWrapper code base less legibile.

Checklist

• There are no public function signature changes
• Any public code that is no longer in use is tagged as obsolete and preserved.
• The code changes have been documented
• The overall behavior does not change

[Mikhinja]

We should decide if we want to deprecate all these methods and keep them one release pointing users to the ToDSType method.