Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reope/performance elementbinder serialization #8

Open
wants to merge 5 commits into
base: reope/performance-base
Choose a base branch
from

Conversation

bendikberg
Copy link
Collaborator

Purpose

Make serialization and deserialization from TraceData faster. Also makes the serialization and deserialization of SerializableId and MultipleSerializableId cleaner.

Uses a specialized de/serializer to skip creating the generic Newtonsoft.Json converter on every deserialization call.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant