Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionManager TransactionGroup strategy #9

Open
wants to merge 1 commit into
base: reope/performance-base
Choose a base branch
from

Conversation

bendikberg
Copy link
Collaborator

@bendikberg bendikberg commented Sep 26, 2024

Purpose

This PR adds a new transaction strategy that uses TransactionGroup under the hood. It is essentially a drop in replacement for the current Automatic transaction strategy, but batches transactions into groups.

The group size can be user defined, so that the old functionality of commiting the transaction at the end of the Dynamo run remains the same. In cases where TransactionManager.TransactionTaskDone is called multiple times, the commits will happen during graph execution instead of after the graph has finished running.

The main inspiration for this PR is this thread on the Autodesk forums

Testing is needed to see if this has the same effect on graph execution time.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@bendikberg bendikberg changed the title Test grouping transaction manager TransactionManager TransactionGroup strategy Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant