TransactionManager TransactionGroup strategy #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a new transaction strategy that uses TransactionGroup under the hood. It is essentially a drop in replacement for the current Automatic transaction strategy, but batches transactions into groups.
The group size can be user defined, so that the old functionality of commiting the transaction at the end of the Dynamo run remains the same. In cases where TransactionManager.TransactionTaskDone is called multiple times, the commits will happen during graph execution instead of after the graph has finished running.
The main inspiration for this PR is this thread on the Autodesk forums
Testing is needed to see if this has the same effect on graph execution time.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of