compiles socks5 in rustc 1.5.0-dev #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jsyk, I tested this and got a successful Tor connection through rustsocks + hyper :) good night |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble compiling this with latest Rust (see #3), so I went ahead and fixed the errors the compiler was giving. Obviously I don't have any real idea what I am doing since this is not my code, and I am not particularly familiar with SOCKS. Nor am I an experienced Rust programmer yet ;)
I need SOCKS5 to work, so I focused on that for the last couple of hours. The same changes should be applicable to the other files but I am not sure I will get to it in the next couple of days.
As for the actual code changes, I was worried at one particular place, where I needed to replace a call to
TcpStream::read_at_least(len, &mut buff)byTcpStream::read_exact(&mut buff). The former has been completely removed fromstd::io::Read, the latter is marked unstable. I am not sure about the semantics ofread_at_least, so I am not sure my change leaves the semantics of the library intact. Would be nice if you could have a look!Thanks,
R