Added new command version. Query the server for client's read-only status. - #57
Open
EricPei20 wants to merge 1 commit into
Open
Added new command version. Query the server for client's read-only status.#57EricPei20 wants to merge 1 commit into
EricPei20 wants to merge 1 commit into
Conversation
CSSFrancis
requested changes
Aug 27, 2026
Member
There was a problem hiding this comment.
I think that it might be better to have the read_only as a getter/setter.
@property
def read_only(self):
command = self._addSingleCommand(self.GET_CLIENT_READ_ONLY, None)
response = self._sendCommand(command)
if response != False:
read_only = self.__getParameters(response.acknowledge[0])[0]
else:
read_only=None
return read_only
@read_only.setter
def read_only(self, read_only):
command = self._addSingleCommand(self.SET_CLIENT_READ_ONLY_DEPRECATED, None, [read_only])
response = self._sendCommand(command)So then you could have client.read_only=False etc...
Right now the problem is that you can do client.read_only=True and the value will change but nothing will actually change... There are lots of things like if the set fails for some reason the value will not actually update.
Member
|
Also if you want the pre-commit test to pass that just requires That installs the pre-commit hook to the repo so it will run a code formatting check/ style update every time that code is committed. Just something that helps to keep things easier to maintain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.