Skip to content

Conversation

@IllagerCaptain
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This future-proofs against Discord potentially making the maximum bitrate for stage channels variable. Currently, it is always 64000. It is also just easier than the user manually typing in 64000 each time they need it.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Skipped Skipped Dec 2, 2025 11:18pm
discord-js-guide Skipped Skipped Dec 2, 2025 11:18pm

@vercel vercel bot temporarily deployed to Preview – discord-js November 27, 2025 02:58 Inactive
@vercel vercel bot temporarily deployed to Preview – discord-js-guide November 27, 2025 02:58 Inactive
@IllagerCaptain IllagerCaptain changed the title Add maximumStageBitrate : number feat: Add maximumStageBitrate : number Nov 27, 2025
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Nov 28, 2025
Jiralite
Jiralite previously approved these changes Nov 28, 2025
@Jiralite Jiralite changed the title feat: Add maximumStageBitrate : number feat: Add maximumStageBitrate: number Nov 28, 2025
Copy link
Member

@sdanialraza sdanialraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing typings

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Nov 28, 2025
@sdanialraza sdanialraza changed the title feat: Add maximumStageBitrate: number feat(Guild): Add maximumStageBitrate Nov 28, 2025
@Jiralite Jiralite dismissed their stale review November 30, 2025 15:12

Changes needed.

@vercel vercel bot temporarily deployed to Preview – discord-js December 1, 2025 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – discord-js-guide December 1, 2025 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – discord-js-guide December 1, 2025 00:44 Inactive
@vercel vercel bot temporarily deployed to Preview – discord-js December 1, 2025 00:44 Inactive
@vercel vercel bot temporarily deployed to Preview – discord-js December 1, 2025 13:18 Inactive
@vercel vercel bot temporarily deployed to Preview – discord-js-guide December 1, 2025 13:18 Inactive
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Dec 2, 2025
@vercel vercel bot temporarily deployed to Preview – discord-js-guide December 2, 2025 23:18 Inactive
@vercel vercel bot temporarily deployed to Preview – discord-js December 2, 2025 23:18 Inactive
@kodiakhq kodiakhq bot merged commit 633fdd8 into discordjs:main Dec 2, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants