DEV: Adds ability to see multiday events in sidebar #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrusselburg
force-pushed
the
br/multiday_event
branch
2 times, most recently
from
06452ef
to
5db5fcf
Compare
brrusselburg
force-pushed
the
br/multiday_event
branch
from
5db5fcf
to
4cd7151
Compare
brrusselburg
force-pushed
the
br/multiday_event
branch
from
4cd7151
to
b8eed11
Compare
jmperez127
requested changes
Oct 25, 2024
assets/javascripts/discourse/components/upcoming-events-list.gjs
Outdated
Show resolved
Hide resolved
assets/javascripts/discourse/components/upcoming-events-list.gjs
Outdated
Show resolved
Hide resolved
brrusselburg
force-pushed
the
br/multiday_event
branch
from
3d3eccd
to
fe59d8f
Compare
jmperez127
reviewed
Oct 29, 2024
assets/javascripts/discourse/components/upcoming-events-list.gjs
Outdated
Show resolved
Hide resolved
jmperez127
approved these changes
Oct 29, 2024
brrusselburg
force-pushed
the
br/multiday_event
branch
from
fe59d8f
to
2e08286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR refers to the interactivity between the discourse-calendar plugin and the right-sidebar-blocks component.)
As of now, only the first day of an event gets listed in the Upcoming Events sidebar. So if the event is from
10-22-2024 to 10-26-2024,only the 22nd would have the event on it. On the 23rd, you wouldn't know the event was still happening.Before:
(Note that this screenshot was taken on October 28th, and the event's start date shows up)
After:
(Taken on the same day, so only the remaining event days show up)
I tested this with both single-day events and multi-day events. We might need to add a limit on the number of results we get back. (If someone throws in a month-long event, it'll get real hairy real quick.) I have some ideas, but I'm not positive of the best place to put that limiter. Ideas welcome!