fix(linux): ensure linux apps can startup#4528
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
refactor(platform): centralize Linux/Windows guards in platform_support Extract repeated 'isFirebaseSupported' and 'hasNativeVideoPlayer' checks into a new web-safe helper (lib/utils/platform_support.dart) so main.dart, crash_reporting_service.dart, and app_providers.dart share a single source of truth instead of duplicating defaultTargetPlatform comparisons. - New helper uses only package:flutter/foundation.dart (no dart:io), so it stays safe under the web conditional import in main.dart. - Renames configureVideoPlayerCacheForStartup parameter 'isWeb' to 'skip' so it matches the broader 'no native video plugin' meaning. - Adds tests for both helpers covering Android/iOS/macOS/Linux/Windows. - Adds an inline comment to the cryptography_flutter Linux stub explaining why the plugin returns NotImplemented (Dart side falls back to package:cryptography). fix(provider): update hash for PushNotificationSyncProvider
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
I pushed a small follow-up commit on top of this PR to close the remaining unsupported-platform startup gap. What changed:
Validation I ran:
|
Mobile PR PreviewPreview refreshed for Last refresh:
|
NotThatKindOfDrLiz
approved these changes
May 19, 2026
Member
NotThatKindOfDrLiz
left a comment
NotThatKindOfDrLiz
left a comment
There was a problem hiding this comment.
Final pass is clean. The Linux startup fix is sound, the unsupported-platform gating is now consistent for both startup video-player calls, and checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4529
Description
The current Linux build no longer works, even though it has officially been supported since #1766 for Flathub users. This PR ensures that everything works correctly again for Linux builds.
Note the pro_video_editor was update to also support the linux build and
DivineVideoPlayerController.disposeAllLinux guard is intentionally deferred — covered by #4487.Related Issue:
Out of Scope
Verification
Type of Change