refactor(providers): split upload & media providers out of app_providers.dart

[realmeylisdev]

Summary

First sub-batch (9a of 3) of #4506's final wave. Refs #4339 Wave 2.

Moves the 10-entity upload/media cluster to lib/providers/upload_media_providers.dart. Cleanest cluster of the entire wave — pure dependency injection, no in-line state machines, no bridges, no follow-up smells.

What moved

Private adapters (preserved through batches 5/7 and now moving with their callers):

• _BlossomAuthAdapter — implements BlossomAuthProvider
• _FirebasePerformanceAdapter — implements BlossomPerformanceMonitor

Media auth chain:

• blossomAuthService
• mediaViewerAuthServiceProvider (legacy Provider<X>(...) style)
• mediaAuthInterceptor

Upload chain:

• blossomUploadService
• uploadManager (top of upload chain)

API + audio:

• apiService (nip98-backed)
• crosspostApiClient (Bluesky-toggle settings)
• audioPlaybackService

Migration pattern

app_providers.dart adds:

```dart
import 'package:openvine/providers/upload_media_providers.dart'; // back-import for bugReportService
// ...
export 'upload_media_providers.dart'; // keeps 28 consumers' imports unchanged
```

• The import is needed because bugReportService (line 945, will move with batch 9c) still consumes blossomUploadServiceProvider.
• The export keeps all 28 external consumer files unchanged.

No mutual import — the new file does NOT import app_providers.dart. All outbound deps reach already-split files: auth_providers.dart (authService, oauthClient, oauthConfig, nip98AuthService), moderation_providers.dart (ageVerificationService, contentFilterService), environment_provider.dart (currentEnvironmentProvider). First batch of the wave with this shape.

Discovered during implementation

AudioPlaybackService lives in the sound_service package, not at openvine/services/audio_playback_service.dart (a path I assumed in the plan and that doesn't exist). Corrected the import.

Scope cleanup

dart fix --apply removed 9 newly-unused imports from app_providers.dart (blossom_upload_service, api_service, auth_service, crosspost_api_client, media_auth_interceptor, media_viewer_auth_service, performance_monitoring_service, upload_manager, audio_playback_service via sound_service).

Codegen moved: 6 *Provider chunks (~378 LoC) relocated from app_providers.g.dart into upload_media_providers.g.dart. Zero duplication (verified via grep).

Test plan

• dart run build_runner build --delete-conflicting-outputs — clean
• flutter analyze lib test integration_test — clean (after dart fix + EOL newline fix)
• flutter test test/widgets/upload_failure_sheet_test.dart test/widgets/report_content_dialog_test.dart — 35 passed
• dart format applied

Cumulative reduction

After 9a: app_providers.dart is 1120 → 978 LoC (66% reduction from original 2,918). Two sub-batches remain to fully exhaust #4506:

• 9b: Repositories (~16 entities — follow/profile/categories/hashtag/curated/people-lists/dm/comments/bookmark/mute)
• 9c: Social + foundation (~13 entities — analytics/social/pendingAction/outgoingDm/collaborator-3/draft/clip/userDataCleanup/bugReport/contentReporting/contentDeletion)

Reviewer

Per established pattern, only NotThatKindOfDrLiz will be added when CI turns green.

[github-actions]

Mobile PR Preview

Preview refreshed for d5f7a37

Last refresh: d5f7a37 at 2026-05-19 05:50:48 UTC (preview run)

Property	Value
Preview URL	https://68476d6d.openvine-app.pages.dev
Pages project	openvine-app
Preview branch	pr-4550
PR branch	refactor/4506-batch-9a-upload-media
Commit	d5f7a37

[rabble]

Code Review

Overview

Pure mechanical extraction of the upload/media provider cluster (10 entities + 2 private adapters) from app_providers.dart to a new upload_media_providers.dart. Net diff: 4 files, +534/-513, all under mobile/lib/providers/. No behavior changes.

Verification performed

Pure move confirmed. Diffed the deleted blocks in app_providers.dart against the new file — _BlossomAuthAdapter, _FirebasePerformanceAdapter, and all 8 providers (blossomAuthService, mediaViewerAuthServiceProvider, mediaAuthInterceptor, blossomUploadService, uploadManager, apiService, crosspostApiClient, audioPlaybackService) are byte-identical in their new home. No drift, no "while I'm here" edits.

Codegen relocation verified. app_providers.g.dart shows 0 leftover references to any of the 8 moved provider symbols; corresponding @ProviderFor blocks all moved cleanly into upload_media_providers.g.dart. No duplication.

Consumer stability confirmed. Re-export from app_providers.dart (export 'upload_media_providers.dart';) means all 20+ consumer files (main.dart, global_upload_indicator.dart, video_providers.dart, sounds_screen.dart, test fixtures, etc.) continue to import via package:openvine/providers/app_providers.dart unchanged. Test overrides in nip05_settings_navigation_test.dart etc. still resolve through the re-export.

Bridge import justified. The kept import 'package:openvine/providers/upload_media_providers.dart'; in app_providers.dart is required because bugReportService (PR line 840) still consumes blossomUploadServiceProvider. PR description correctly flags this as a temporary bridge until batch 9c moves bugReportService.

Bloc-bridge identity rule (state_management.md). Searched for ref.read(<moved provider>) calls inside BlocProvider.create: factories — none found. The ref.read sites in individual_video_providers.dart and main.dart are inside Riverpod provider bodies and a Riverpod container init respectively, where the bridge rule doesn't apply. No regression introduced.

Lazy-create gotcha (state_management.md). None of the moved providers had side effects in their create: factory that depended on eager construction; the relocation doesn't change initialization timing.

Outbound deps. The new file imports only already-split sibling files (auth_providers.dart, moderation_providers.dart, environment_provider.dart) — no mutual import with app_providers.dart, matching the pattern claimed in the PR description.

Scope discipline. Diff is exactly the relocation; no unrelated changes, no new providers, no logic edits. dart fix --apply cleanup of 9 newly-unused imports is appropriate.

Findings

No blocking issues, no nits.

Verdict

LGTM. Cleanly-scoped mechanical refactor with no behavior change, no regressions to the rules-of-concern (lazy create, bridge identity), no dead code, no scope creep. Approve.

[NotThatKindOfDrLiz]

Reviewed the extraction locally and against the PR diff. Safe mechanical split; approving. Follow-up issue filed for the remaining transitive provider dependency cleanup.

[NotThatKindOfDrLiz]

Reviewed the extraction locally and against the PR diff. Safe mechanical split; approving. Follow-up issue filed for the remaining transitive provider dependency cleanup.