Skip to content

feat(hot): use sort=watching for 24h view-based ranking #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rabble wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(hot): use sort=watching for 24h view-based ranking #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hooks/useInfiniteVideosFunnelcake.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import { performanceMonitor } from '@/lib/performanceMonitoring';

export type FunnelcakeFeedType = 'trending' | 'recent' | 'classics' | 'hashtag' | 'profile' | 'home' | 'recommendations' | 'category';
export type FunnelcakeSortMode = 'trending' | 'recent' | 'loops' | 'engagement' | 'classic';
export type FunnelcakeSortMode = 'trending' | 'recent' | 'loops' | 'engagement' | 'classic' | 'watching';

interface UseInfiniteVideosFunnelcakeOptions {
feedType: FunnelcakeFeedType;
Expand Down Expand Up @@ -109,7 +109,7 @@
case 'trending':
return {
...baseOptions,
sort: sortMode === 'classic' ? 'loops' : (sortMode || 'trending'),

Check failure on line 112 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.

Check failure on line 112 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.
...(sortMode === 'classic' ? { classic: true, platform: 'vine' } : {}),
};

Expand All @@ -122,28 +122,28 @@
case 'hashtag':
return {
...baseOptions,
sort: sortMode === 'classic' ? 'loops' : (sortMode || 'trending'),

Check failure on line 125 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.

Check failure on line 125 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.
...(sortMode === 'classic' ? { classic: true, platform: 'vine' } : {}),
};

case 'profile':
return {
...baseOptions,
sort: sortMode === 'classic' ? 'loops' : (sortMode || 'recent'),

Check failure on line 132 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.

Check failure on line 132 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.
...(sortMode === 'classic' ? { classic: true, platform: 'vine' } : {}),
};

case 'home':
return {
...baseOptions,
sort: sortMode === 'classic' ? 'loops' : (sortMode || 'recent'),

Check failure on line 139 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.

Check failure on line 139 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.
...(sortMode === 'classic' ? { classic: true, platform: 'vine' } : {}),
};

case 'category':
return {
...baseOptions,
sort: sortMode === 'classic' ? 'loops' : (sortMode || 'trending'),

Check failure on line 146 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.

Check failure on line 146 in src/hooks/useInfiniteVideosFunnelcake.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

Type '"trending" | "recent" | "loops" | "engagement" | "watching"' is not assignable to type '"trending" | "recent" | "popular" | "loops" | "engagement" | undefined'.
...(sortMode === 'classic' ? { classic: true, platform: 'vine' } : {}),
};

Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useVideoProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function mapToFunnelcakeSortMode(sortMode?: SortMode): FunnelcakeSortMode | unde

switch (sortMode) {
case 'hot':
return 'trending';
return 'watching';
case 'top':
return 'loops';
case 'rising':
Expand Down
Loading