test(social): add unit tests for useOptimisticLike and useOptimisticRepost#345
Open
DSanich wants to merge 1 commit into
Open
test(social): add unit tests for useOptimisticLike and useOptimisticRepost#345DSanich wants to merge 1 commit into
DSanich wants to merge 1 commit into
Conversation
🚀 Preview Deployment
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/hooks/useOptimisticLike.test.tscovering optimisticvideo-social-metrics/video-user-interactionsupdates, kind 5 delete when unliking with a stored like event id, kind 7 like publish withe/a/ptags (includingvineId: nulladdress form), skip publish when unliking without an event id,likeCountfloored at 0 on unlike, and rollback + destructive toast whenpublishEventfails (like and unlike paths).src/hooks/useOptimisticRepost.test.tscovering kind 5 un-repost,repostVideoarguments and returnedrepostEventId, skip publish when removing repost without an event id,repostCountfloored at 0, and rollback whenrepostVideoor kind 5 delete fails.Motivation
useOptimisticLikeanduseOptimisticRepostpower high-traffic social UI but had no colocated tests; components only mocked these hooks, so cache keys, optimistic deltas, Nostr publish calls, and error rollback were easy to regress silently.Related Issue
Testing
npm run testVisuals