test(comments): extract NIP-22 tag builder and add usePostComment tests#346
Open
DSanich wants to merge 1 commit into
Open
test(comments): extract NIP-22 tag builder and add usePostComment tests#346DSanich wants to merge 1 commit into
DSanich wants to merge 1 commit into
Conversation
🚀 Preview Deployment
|
3 tasks
Contributor
|
Is there an issue that this is in relation to? If not, I suggest opening one so we can discuss the merit of this. This is in lieu of the contributing guidelines. EDIT: I see it, going to review that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildNip22CommentTags(root, reply?)intosrc/lib/buildNip22CommentTags.ts— pure NIP-22 (kind 1111) tag construction previously inlined inusePostComment(URL vs event roots, addressable/replaceable/regular kinds, reply vs top-level branches).usePostCommentto call the helper insidemutationFnso publish payloads stay identical while logic becomes unit-testable.buildNip22CommentTags.test.tswith fixtures for addressable short-video roots (kind 34236), regular/replaceable roots, URL roots, threaded replies (including reply-as-URL).usePostComment.test.tswith mockeduseNostrPublish/useCurrentUser: assertspublishEventreceiveskind: 1111and matching tags (includingreply); exercisescancelQueries, deferred-publish optimistic UI,onSuccessreplacement +invalidateQueriesafter the 6s delay (fake timers), andonErrorrollback.Motivation
publishEventbehaviour.Related Issue
Testing
npm run testVisuals