Skip to content

chore(ci): use absolute KEYCAST_BINARY in e2e workflow#193

Open
sergey3bv wants to merge 2 commits into
divinevideo:mainfrom
sergey3bv:chore/absolute-path-workflow
Open

chore(ci): use absolute KEYCAST_BINARY in e2e workflow#193
sergey3bv wants to merge 2 commits into
divinevideo:mainfrom
sergey3bv:chore/absolute-path-workflow

Conversation

@sergey3bv
Copy link
Copy Markdown
Contributor

Summary

  • Made KEYCAST_BINARY absolute in GitHub workflow.

Avoid naming corporate partners, customers, or other sensitive external brands in this PR title or body. Use generic descriptors unless a maintainer explicitly approves the public reference.

Motivation

Related Issue

Testing

  • cargo test --workspace --verbose
  • cargo clippy --workspace --all-targets --all-features -- -D warnings -A deprecated
  • cargo fmt --all -- --check
  • Manual verification completed

Visuals

  • UI/web change with screenshots/video attached
  • No visual change
  • Visuals and text avoid sensitive external brand or partner names unless explicitly approved

Copy link
Copy Markdown
Contributor

@dcadenas dcadenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This matches the hub-reviewed change for keycast#177: the e2e workflow now uses an absolute KEYCAST_BINARY and reuses it for migrations and the background server.

Copy link
Copy Markdown
Contributor

@dcadenas dcadenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved after updating the branch with latest main. Checks are passing and the diff still matches keycast#177.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): make KEYCAST_BINARY absolute in the e2e GitHub Actions workflow

2 participants