Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

feat: Consolidate kpi functions#434

Open
finnianjs wants to merge 6 commits intomainfrom
finnian0826/kpi-consolidation
Open

feat: Consolidate kpi functions#434
finnianjs wants to merge 6 commits intomainfrom
finnian0826/kpi-consolidation

Conversation

@finnianjs
Copy link
Contributor

@finnianjs finnianjs commented Aug 21, 2025

Lots of campaigns are either looking at gas or tx count on a given chain, make a single kpi function that does these and reuse in place of custom kpi functions for each.

@finnianjs finnianjs marked this pull request as ready for review August 22, 2025 20:22
Copy link
Contributor

@MuckT MuckT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finnian0826, is there an easy way to check how these will look on the docs site?

@finnianjs
Copy link
Contributor Author

@finnian0826, is there an easy way to check how these will look on the docs site?

@MuckT ahh I hadn't thought about docs, I think (???) they get pulled from the campaign specific index files, so maybe the existing ones wouldn't be affected, but for future campaigns this could become a problem since we wouldn't create the campaign specific file and instead just use this generic one.

Maybe this is something that needs to be discussed more before this gets merged. If we are moving toward more generic kpi calculation maybe only have docs for the generic functions and then each something where each campaign just says which generic kpi function is used. But this gets tricky for more complex campaigns like tether, so I'm not sure.

@jeanregisser
Copy link
Member

jeanregisser commented Aug 29, 2025

Maybe this is something that needs to be discussed more before this gets merged. If we are moving toward more generic kpi calculation maybe only have docs for the generic functions and then each something where each campaign just says which generic kpi function is used. But this gets tricky for more complex campaigns like tether, so I'm not sure.

+1 to discuss first before meging this. 🙏
Maybe at the next eng team meeting? or async on Slack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants