Conversation
@MuckT ahh I hadn't thought about docs, I think (???) they get pulled from the campaign specific index files, so maybe the existing ones wouldn't be affected, but for future campaigns this could become a problem since we wouldn't create the campaign specific file and instead just use this generic one. Maybe this is something that needs to be discussed more before this gets merged. If we are moving toward more generic kpi calculation maybe only have docs for the generic functions and then each something where each campaign just says which generic kpi function is used. But this gets tricky for more complex campaigns like tether, so I'm not sure. |
+1 to discuss first before meging this. 🙏 |
Lots of campaigns are either looking at gas or tx count on a given chain, make a single kpi function that does these and reuse in place of custom kpi functions for each.