Skip to content

Conversation

cwe-dixa
Copy link

scala-cli can download the correct scala native binary of scalafmt on demand, which has an even faster startup time. Just think of all the seconds we'll save!

scala-cli can download the correct scala native binary of scalafmt on
demand, which has an even faster startup time. Just think of all the
seconds we'll save!
@cwe-dixa cwe-dixa marked this pull request as ready for review August 20, 2025 08:42
@cwe-dixa cwe-dixa requested a review from a team as a code owner August 20, 2025 08:42
nicolas-dixa
nicolas-dixa previously approved these changes Aug 20, 2025
Copy link

@nicolas-dixa nicolas-dixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 👍

Copy link

@razvanz razvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider making 2 separate hooks: one for scalafmt and another for scala-cli.

razvanz
razvanz previously approved these changes Aug 20, 2025
Copy link

@razvanz razvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that instead of listing with scalafmt, you could also list all the staged files with git diff --cached --name-only. After all, git add does not complain if you add a file that's already staged.

That should make it even faster :)

razvanz
razvanz previously approved these changes Aug 20, 2025
Copy link

@razvanz razvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only QoL stuff.

@cwe-dixa cwe-dixa merged commit e087a9c into master Aug 21, 2025
@cwe-dixa cwe-dixa deleted the feature/use-native-binaries branch August 21, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants