Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Quirks Support - Miranda #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

brong
Copy link
Contributor

@brong brong commented Oct 11, 2012

Deal with Miranda setting roster with a null id on the iq

One thing we ran into with inerop testing a few years ago, and it's been sitting around gathering dust in our local clone.

Deal with Miranda setting roster with a null id on the iq
return unless defined($self->id) && length($self->id);
#
# ... unless this is Miranda because, at least up until 0.78, it sends
# roster updates without an id, oops.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://www.miranda-im.org/download/ says the latest version is 0.10.4, is this still relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Thu, Oct 11, 2012, at 09:13 PM, Ask Bjørn Hansen wrote:

In lib/DJabberd/IQ.pm:

@@ -45,7 +46,17 @@ sub process {
# Trillian Jabber 3.1 is stupid and sends a lot of IQs (but non-important
ones)
# without ids. If we respond to them (also without ids, or with id='', r
ather),
# then Trillian crashes. So let's just ignore them.

  • return unless defined($self->id) && length($self->id);
  • ... unless this is Miranda because, at least up until 0.78, it sends

  • roster updates without an id, oops.

[1]http://www.miranda-im.org/download/ says the latest version is
0.10.4, is this still relevant?


Reply to this email directly or [2]view it on GitHub.
[J6T91GIPIyhU-8ti4GCGP5NqroswussYHXjwGAe6TA5tGDkGY_zFHhDlYCs5jmFL.gi
f]

Probably not. I guess nobody is running it any more :)
Bron.

References

  1. http://www.miranda-im.org/download/

2. https://github.com/djabberd/DJabberd/pull/23/files#r1822466

Bron Gondwana
[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants