Add Open in Editor support for template paths #2198
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobond
force-pushed
the
open-in-editor
branch
from
5102676 to
543c143
Compare
|
|
||
| This function is passed a file path and should return a URL to open the file in | ||
| the editor. For example, to open the file in VS Code, you can use: | ||
| ``lambda f: f"vscode://file/{f}"`` |
There was a problem hiding this comment.
Is this ever not going to be a static prefix with the filename after it? I think if we can remove the lambda, that would be better.
There was a problem hiding this comment.
Not in every case, but an alternative is to own the different formats ourselves like the PHP Debug Bar does.
It's a better UX for most people and lets us add line references later at the cost of a more restricted set of supported editors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a setting to configure an Open in editor URL when you click on a template path. Makes it easier to jump directly to the template and edit. Can develop it further and/or add tests if there is interest in the feature.
Checklist:
docs/changes.rst.