fix: return first PolymorphicParentModelAdmin#894
Open
niltonpimentel02 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the admin redirect/parent-admin selection logic in PolymorphicChildModelAdmin so it prefers the first PolymorphicParentModelAdmin found up the model MRO, rather than returning an arbitrary registered root ModelAdmin. This addresses issue #863 where saving a child model could redirect to the wrong (root) changelist.
Changes:
- Update
_get_parent_admin()to scan the model MRO and return the first registeredPolymorphicParentModelAdmin, skipping regularModelAdminregistrations on the root model. - Add a regression test ensuring a registered root
ModelAdminis ignored when aPolymorphicParentModelAdminexists higher in the hierarchy.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/polymorphic/admin/childadmin.py |
Adjusts _get_parent_admin() to return the first PolymorphicParentModelAdmin in the MRO instead of returning the root model’s admin unconditionally. |
src/polymorphic/tests/test_admin.py |
Adds a test reproducing the root-admin redirect bug and verifying the corrected selection behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone! Based on @bckohan’s comment, I decided to create a test to reproduce the error and verify the fix as well.
Please let me know if I missed anything. Thanks!
Closes #863