Skip to content

Conditions addition to insert_row #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conditions addition to insert_row #1359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01cc3f5
Conditions the addition to `insert_row` within `create_historical_rec…
rgs258 Jun 26, 2024
37c3f99
Merge branch 'jazzband:master' into 1358-condition-insert_row-in-crea…
rgs258 Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions simple_history/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,6 @@ def create_historical_record_m2ms(self, history_instance, instance):
m2m_history_model = self.m2m_models[field]
original_instance = history_instance.instance
through_model = getattr(original_instance, field.name).through
through_model_field_names = [f.name for f in through_model._meta.fields]
through_model_fk_field_names = [
f.name for f in through_model._meta.fields if isinstance(f, ForeignKey)
]
Expand All @@ -722,8 +721,14 @@ def create_historical_record_m2ms(self, history_instance, instance):
for row in rows:
insert_row = {"history": history_instance}

for field_name in through_model_field_names:
insert_row[field_name] = getattr(row, field_name)
for through_model_field in through_model._meta.fields:
# Remove any excluded kwargs for the field.
if through_model_field.name not in self.field_excluded_kwargs(
field
):
insert_row[through_model_field.name] = getattr(
row, through_model_field.name
)
insert_rows.append(m2m_history_model(**insert_row))

pre_create_historical_m2m_records.send(
Expand Down