Skip to content

Conversation

@ddabble
Copy link
Member

@ddabble ddabble commented Dec 11, 2025

Description

See title.

Related Issue

Motivation and Context

When drafting the newest release, I noticed that the generated release notes contained PRs from both Dependabot and the pre-commit-ci bot, so this should fix it.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

When drafting the newest release, I noticed that the generated release
notes contained PRs from both Dependabot and the pre-commit-ci bot, so
this should fix it.
@ulgens
Copy link
Member

ulgens commented Dec 11, 2025

Will check it later. I think we should disable the pre commit bot all together, but having entries for package update doesn't sound bad.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddabble
Copy link
Member Author

ddabble commented Dec 11, 2025

@ulgens Yeah, the automatic hook version updates are very useful, and I'm not aware of any (well-established) GitHub Action that can do the same 🤔

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. I will be using this for the toolbar as well now 😁

@ulgens
Copy link
Member

ulgens commented Dec 12, 2025

Oh, just realized this doesn't add a new feature but fixing an existing one. Approving it.

Though, are we sure about excluding dependency update info from the changelog? I think they are useful when they don't create much noise.

@tim-schilling
Copy link
Member

Personally, I'd remove them from the changelog 🤷 I'll defer to @ddabble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants